You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/06/03 05:50:23 UTC
[jira] [Commented] (ZOOKEEPER-1478) Small bug in
QuorumTest.testFollowersStartAfterLeader( )
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288072#comment-13288072 ]
Hadoop QA commented on ZOOKEEPER-1478:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530678/ZOOKEEPER-1478.patch
against trunk revision 1337029.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1086//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1086//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1086//console
This message is automatically generated.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
> --------------------------------------------------------
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Minor
> Attachments: ZOOKEEPER-1478.patch
>
>
> The following code appears in QuorumTest.testFollowersStartAfterLeader( ):
> for (int i = 0; i < 30; i++) {
> try {
> zk.create("/test", "test".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE,
> CreateMode.PERSISTENT);
> break;
> } catch(KeeperException.ConnectionLossException e) {
> Thread.sleep(1000);
> }
> // test fails if we still can't connect to the quorum after 30 seconds.
> Assert.fail("client could not connect to reestablished quorum: giving up after 30+ seconds.");
> }
> From the comment it looks like the intention was to try to reconnect 30 times and only then trigger the Assert, but that's not what this does.
> After we fail to connect once and Thread.sleep is executed, Assert.fail will be executed without retrying create.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira