[GitHub] [apisix] Firstsawyou commented on a change in pull request #3842: fix(traffic-split): binding upstream via upstream_id is invalid

[GitBox <gi...@apache.org>]

Firstsawyou commented on a change in pull request #3842:
URL: https://github.com/apache/apisix/pull/3842#discussion_r595677287



##########
File path: apisix/init.lua
##########
@@ -387,6 +387,13 @@ function _M.http_access_phase()
     end
 
     local up_id = route.value.upstream_id
+
+    -- used for the traffic-split plugin
+    if route.value.upstream_id_tmp then

Review comment:
       Do you mean to directly set the variable of `ctx.upstream_id` in the traffic-split plugin to cache the upstream_id in the plugin?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org