You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@wandisco.com> on 2012/05/11 01:50:59 UTC

Re: svn commit: r657 - in /dev/subversion: subversion-1.7.5.tar.bz2.asc subversion-1.7.5.tar.gz.asc subversion-1.7.5.zip.asc

stsp@apache.org writes:

> Author: stsp
> Date: Thu May 10 22:27:49 2012
> New Revision: 657
>
> Log:
> Remove binary svn:mime-type from 1.7.5 .asc signature files, and set their
> eol-style to 'native'. See http://svn.haxx.se/dev/archive-2012-04/0227.shtml

The files already had 'native' svn:eol-style.  The reason they had
svn:mime-type set is that I used a Subversion client with libmagic
support.  I suppose release.py could explicitly set text/plain, or we
could set the MAGIC environment variable to some non-existent path.

> Modified:
>     dev/subversion/subversion-1.7.5.tar.bz2.asc   (props changed)
>     dev/subversion/subversion-1.7.5.tar.gz.asc   (props changed)
>     dev/subversion/subversion-1.7.5.zip.asc   (props changed)
>
> Propchange: dev/subversion/subversion-1.7.5.tar.bz2.asc
>             ('svn:mime-type' removed)
>
> Propchange: dev/subversion/subversion-1.7.5.tar.gz.asc
>             ('svn:mime-type' removed)
>
> Propchange: dev/subversion/subversion-1.7.5.zip.asc
>             ('svn:mime-type' removed)

-- 
Philip

Re: svn commit: r657 - in /dev/subversion: subversion-1.7.5.tar.bz2.asc subversion-1.7.5.tar.gz.asc subversion-1.7.5.zip.asc

Posted by Greg Stein <gs...@gmail.com>.
On May 10, 2012 1:51 PM, "Philip Martin" <ph...@wandisco.com> wrote:
>
> stsp@apache.org writes:
>
> > Author: stsp
> > Date: Thu May 10 22:27:49 2012
> > New Revision: 657
> >
> > Log:
> > Remove binary svn:mime-type from 1.7.5 .asc signature files, and set
their
> > eol-style to 'native'. See
http://svn.haxx.se/dev/archive-2012-04/0227.shtml
>
> The files already had 'native' svn:eol-style.  The reason they had
> svn:mime-type set is that I used a Subversion client with libmagic
> support.  I suppose release.py could explicitly set text/plain, or we
> could set the MAGIC environment variable to some non-existent path.

I think the explicit text/plain is best. IIRC, we're also setting the mime
type on some of the other files.

We should be explicit rather than relying on magic/not.

Cheers,
-g