You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "abderrahim (via GitHub)" <gi...@apache.org> on 2024/10/31 20:41:27 UTC
[PR] _stream: Only query cache for the requested elements [buildstream]
abderrahim opened a new pull request, #1965:
URL: https://github.com/apache/buildstream/pull/1965
query_cache() used to query the cache for the elements passed and all their (build and runtime) dependencies. This is wasteful since most of the time, we don't need all this cache query. And for the cases we need, it is the job of the query_cache() caller to include the dependencies they need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] _stream: Only query cache for the requested elements [buildstream]
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan merged PR #1965:
URL: https://github.com/apache/buildstream/pull/1965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] _stream: Only query cache for the requested elements [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on PR #1965:
URL: https://github.com/apache/buildstream/pull/1965#issuecomment-2464243964
I think this makes sense. However, do I see this right that it doesn't make a difference for typical builds as we always load all elements to support dynamic planning (unless `--deps build` is specified)? So this is mainly an optimization for non-build commands, or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] _stream: Only query cache for the requested elements [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on PR #1965:
URL: https://github.com/apache/buildstream/pull/1965#issuecomment-2464320379
> I think this makes sense. However, do I see this right that it doesn't make a difference for typical builds as we always load all elements to support dynamic planning (unless --deps build is specified)? So this is mainly an optimization for non-build commands, or am I missing something?
That's correct. The main optimisation here is for artifact checkout.
The commit message here hasn't been updated to cover my most recent findings. I'll try to update it later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org