[GitHub] [hbase] bharathv commented on a change in pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #2274:
URL: https://github.com/apache/hbase/pull/2274#discussion_r472503645



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
##########
@@ -69,7 +65,14 @@
  */
 @InterfaceAudience.Public
 public interface RegionInfo extends Comparable<RegionInfo> {
-  RegionInfo UNDEFINED = RegionInfoBuilder.newBuilder(TableName.valueOf("__UNDEFINED__")).build();
+  /**
+   * Do not use.
+   * @deprecated Since 2.3.1; to be removed in 4.0.0 with no replacement.
+   */
+  // Removed because creation was creating a static deadlock, HBASE-24896
+  @Deprecated
+  RegionInfo UNDEFINED = null;

Review comment:
       Was wondering if we can move the following into RegionInfo to avoid this deprecation stuff. For that we will have to switch to RegionInfoBuilder c'tor because the following usage is a private c'tor. Curious if you considered that and didn't want to do it for some reason. The c'tor was specifically designed for this usecase, so I may be missing some context here.
   
   public static final RegionInfo FIRST_META_REGIONINFO =
       new MutableRegionInfo(1L, TableName.META_TABLE_NAME, RegionInfo.DEFAULT_REPLICA_ID);




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org