You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/26 09:12:13 UTC
[GitHub] [netbeans] dmochalov opened a new pull request #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
dmochalov opened a new pull request #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
URL: https://github.com/apache/netbeans/pull/2047
See the [issue ]( https://issues.apache.org/jira/browse/NETBEANS-4070) for details.
Simple code changes: moved if block `if (element.getKind() == ElementKind.METHOD) {` outside of `for (DocTree tag : tags) {` loop and added some comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
URL: https://github.com/apache/netbeans/pull/2047#issuecomment-605462758
I think this one is safe to be merged in 12.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
URL: https://github.com/apache/netbeans/pull/2047#issuecomment-611716891
What is the behavior in Javadoc generated by the javadoc tool? Does it do the same?
(One could argue that the superclass description _should_ be included, as the subclass is bound to follow the requirements set there. But I would say, do whatever the behavior of the javadoc tool is.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dmochalov commented on issue #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
Posted by GitBox <gi...@apache.org>.
dmochalov commented on issue #2047: [NETBEANS-4070] fixed JavaDoc in tooltip (ctrl+mouse hover) duplicate…
URL: https://github.com/apache/netbeans/pull/2047#issuecomment-612386680
@eirikbakke thank you for taking time to review it.
Indeed Javadoc handles it differently. It does not include the Javadoc of a parent method. Also, I checked the Eclipse's tooltip - it doesn't include the parent Javadoc at all.
But in the NetBeans, there is a whole bunch of code to handle it. The bug here is just how NetBeans combines a description of parameters.
Before fixing NetBeans dose it in that way:
i.e for the index it combines Javadoc both from parent and from the current method and does it a little awkwardly.
for the c parameter, it only adds Javadoc from the parent method.
After fixing NetBeans dose it in that way:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists