You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/10/15 03:13:57 UTC
[kudu-CR] wip ksck: print tablet server states
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14436
Change subject: wip ksck: print tablet server states
......................................................................
wip ksck: print tablet server states
TODO: add tests
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
9 files changed, 103 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/1
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] ksck: print tablet server states
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 22:23:03 +0000
Gerrit-HasComments: No
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14436
to look at the new patch set (#7).
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/7
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@522
PS3, Line 522: // is the state, so move on.
> Went for EmplaceOrUpdate.
Fair enough, but shouldn't we also use EmplaceOrUpdate on L533 then?
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 22:13:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14436
to look at the new patch set (#4).
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/4
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14436
to look at the new patch set (#3).
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 136 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/3
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Reviewed-on: http://gerrit.cloudera.org:8080/14436
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 31 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 23:00:26 +0000
Gerrit-HasComments: No
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14436/6/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:
http://gerrit.cloudera.org:8080/#/c/14436/6/src/kudu/tools/ksck_remote.cc@530
PS6, Line 530: EmplaceOrUpdate(&tablet_servers, uuid, std::move(ts));
> warning: 'ts' used after it was moved [bugprone-use-after-move]
Done
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 22:26:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@522
PS3, Line 522: // is the state, so move on.
> Fair enough, but shouldn't we also use EmplaceOrUpdate on L533 then?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 22:16:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14436
to look at the new patch set (#6).
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/6
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14436
to look at the new patch set (#5).
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/5
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@511
PS3, Line 511:
: TSMap tablet_servers;
: KsckTServerStateMap ts_states;
: for (int i = 0; i < resp.servers_size(); i++) {
> Don't need this anymore?
Done
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@522
PS3, Line 522: // If there's no registration for the tablet server, all we can really get
> Why not EmplaceOrDie here?
Went for EmplaceOrUpdate.
Update vs die is me just being conservative. I'd prefer to be conservative because ksck is incredibly important, and having it crash when you need it seems scary.
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:28:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] ksck: print tablet server states
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@511
PS3, Line 511:
: vector<KuduTabletServer*> servers;
: ElementDeleter deleter(&servers);
: RETURN_NOT_OK(client_->ListTabletServers(&servers));
Don't need this anymore?
http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@522
PS3, Line 522: InsertOrUpdate(&ts_states, uuid, ts_pb.state());
Why not EmplaceOrDie here?
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 20:57:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14436
to look at the new patch set (#2).
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 136 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14436/2
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ksck: print tablet server states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14436/4/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:
http://gerrit.cloudera.org:8080/#/c/14436/4/src/kudu/tools/ksck_remote.cc@85
PS4, Line 85: using kudu::client::internal::ReplicaController;
> warning: using decl 'KuduTabletServer' is unused [misc-unused-using-decls]
Done
--
To view, visit http://gerrit.cloudera.org:8080/14436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14436
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:51:24 +0000
Gerrit-HasComments: Yes