You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/09/22 12:12:56 UTC

[PR] fix(web): warn on partially matched DLQ selected resends instead of success [rocketmq-dashboard]

Frun1na opened a new pull request, #4912:
URL: https://github.com/apache/rocketmq-dashboard/pull/4912

   ### Which Issue(s) This PR Fixes
   
   - Fixes #(issue to be linked)
   
   ### Brief Description
   
   `resendSelectedMessages` only branched on `outcome === 'FAILED'` and `failed > 0`. The server reports `matched` separately: a selected message that can no longer be resolved (purged, broker gone) is dropped with `failed = 0`, so the old code fell through to a green `重发完成:成功 X 条` toast. The handler now mirrors the time-range resend path and warns whenever `unmatched > 0 || failed > 0 || scanIncomplete`.
   
   ### How Did You Test This Change?
   
   ```
   cd web && npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx
   
   Test Files  1 passed (1)
        Tests  22 passed (22)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(web): warn on partially matched DLQ selected resends instead of success [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #4912:
URL: https://github.com/apache/rocketmq-dashboard/pull/4912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(web): warn on partially matched DLQ selected resends instead of success [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #4912:
URL: https://github.com/apache/rocketmq-dashboard/pull/4912#issuecomment-6093174658

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(web): warn on partially matched DLQ selected resends instead of success [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #4912:
URL: https://github.com/apache/rocketmq-dashboard/pull/4912#issuecomment-5934672373

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(web): warn on partially matched DLQ selected resends instead of success [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #4912:
URL: https://github.com/apache/rocketmq-dashboard/pull/4912#issuecomment-6044093760

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org