[GitHub] [pinot] mqliang edited a comment on pull request #7540: Always enable the ThreadTimer

[GitBox <gi...@apache.org>]

mqliang edited a comment on pull request #7540:
URL: https://github.com/apache/pinot/pull/7540#issuecomment-938413650


   @Jackie-Jiang 
   > Based on the discussion, I feel it is not a good idea to enable it by default. I'd suggest putting -1 as ThreadCpuTimeNs if it is not enabled as a clear indication to the users that it is not enabled as @richardstartin suggested. What do you think?
   
   I am not very concerned about the default value. I am more concerned about deleting the flag -- it's NOT a back compatible change, if user already start use the flag, after upgrading, pinot process will panic as user pass in a nonexistent flag.  
   
   Agree that disable by default as recording thread CPU time can be expensive.
   
   Agree that putting -1 or 0  as ThreadCpuTimeNs if it is not enabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org