You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ponymail.apache.org by GitBox <gi...@apache.org> on 2021/08/01 09:03:27 UTC
[GitHub] [incubator-ponymail-foal] sbp opened a new pull request #50: Improve and document the thread info code
sbp opened a new pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50
Resolves #49.
This PR moves the `forum` and `size` properties to the standard Foal database entry for an archived email. The existing code for `top`, `previous`, and `thread` from #43 is retained, but improved: two new `threadparents` and `threadtimeout` properties bound the execution time of querying the new properties. The addition of these properties is optional, and is off by default. The documentation now explains their usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sbp commented on pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
sbp commented on pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50#issuecomment-890483135
It only searches for the first parent that exists, rather than trying to model the entire tree. Since an email will usually only reference emails that already exist, this should mean that it will normally exit on the very first reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh merged pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
Humbedooh merged pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh commented on pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50#issuecomment-890481582
I wonder if 10 is large enough for the default `threadparents` value.
At least for ASF, I've seen threads that can nest 20-fold or sometimes more, as we can have a 100-email long thread where each new email is a reply to the old.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh commented on pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50#issuecomment-890485575
so it only references the immediate parent, and not the top of the thread? or?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sbp commented on pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
sbp commented on pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50#issuecomment-890494877
Yeah it searches only for the immediate parent, but then it does that transitively: it'll search the parent for its references, getting the parent's parent, and so on all the way to the top. That way it doesn't depend on clients including references to every ancestor in the thread. I think I copied the code that Ponymail itself uses when computing threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sbp commented on pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
sbp commented on pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50#issuecomment-890912978
I mean it already expects its parent to have had its thread information computed because the parent will already have been received and had the same process run on it. It doesn't have to recompute the entire thread every time a new email is received, it just finds the immediate parent and then it has all the necessary thread information, since e.g. the parent will already have a link to the top of the thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh merged pull request #50: Improve and document the thread info code
Posted by GitBox <gi...@apache.org>.
Humbedooh merged pull request #50:
URL: https://github.com/apache/incubator-ponymail-foal/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org