You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Stan Lewis (Created) (JIRA)" <ji...@apache.org> on 2011/12/06 20:15:41 UTC
[jira] [Created] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Add DefaultTestAppender utility abstract class
----------------------------------------------
Key: AMQ-3623
URL: https://issues.apache.org/jira/browse/AMQ-3623
Project: ActiveMQ
Issue Type: New Feature
Components: Test Cases
Affects Versions: 5.5.1
Reporter: Stan Lewis
Priority: Minor
Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Stan Lewis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163754#comment-13163754 ]
Stan Lewis commented on AMQ-3623:
---------------------------------
Patch adds DefaultTestAppender and modifies the two existing tests to use it.
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Priority: Minor
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Stan Lewis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165427#comment-13165427 ]
Stan Lewis commented on AMQ-3623:
---------------------------------
Yeah, totally agree, sorry I missed that. We get away with it currently because of the way the tests are run but it's best the test cleans that up, will attach a second patch momentarily.
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Stan Lewis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stan Lewis updated AMQ-3623:
----------------------------
Attachment: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Priority: Minor
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Stan Lewis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165428#comment-13165428 ]
Stan Lewis commented on AMQ-3623:
---------------------------------
Yeah, totally agree, sorry I missed that. We get away with it currently because of the way the tests are run but it's best the test cleans that up, will attach a second patch momentarily.
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Gary Tully (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully reassigned AMQ-3623:
-------------------------------
Assignee: Gary Tully
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Assignee: Gary Tully
> Priority: Minor
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Claudio Corsi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165420#comment-13165420 ]
Claudio Corsi commented on AMQ-3623:
------------------------------------
I looked at the patch and I just noticed that the appender is added to the logging system but it is not removed when the test has completed.
Since the appender references the test case then the test case instance will never be reclaimed until the logging system is removed and that is when the application ends.
Would you consider adding the code that remove the added appender when the test has completed.
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Gary Tully (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully resolved AMQ-3623.
-----------------------------
Resolution: Fixed
Fix Version/s: 5.6.0
improvement applied with thanks.
note for the future, every new file needs the apache copyright header :-)
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3623) Add DefaultTestAppender utility
abstract class
Posted by "Stan Lewis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165439#comment-13165439 ]
Stan Lewis commented on AMQ-3623:
---------------------------------
Created AMQ-3628 for the fix since this feature's been added.
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
> Key: AMQ-3623
> URL: https://issues.apache.org/jira/browse/AMQ-3623
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Test Cases
> Affects Versions: 5.5.1
> Reporter: Stan Lewis
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira