[jira] Updated: (GERONIMO-3010) Proposal for tomcat to change managed object construction/annotation processing

["David Jencks (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks updated GERONIMO-3010:
-----------------------------------

    Attachment: GERONIMO-3010-3.patch

New patch for tomcat/jasper.  This one might be ready for the tomcat folks to look at.
- uses "InstanceManager" instead of "LifecycleProvider", thanks dblevins for the improved name
- implements xml overrides of annotations per suggestion of Remy
- postConstruct and preDestroy annotated methods are called for all superclasses as well as actual class per spec
- Jasper does not use the catalina InstanceManager, it has it's own interface.  This means tomcat includes a jasper class (for the tomcat implementations of InstanceManager) but that jasper includes no catalina classes, and avoids any classes in a non-tomcat package (org.apache)

Also includes a new servlet example EnvEntryExample which crudely demonstrates that the env entry annotations work and that xml override works.

Put in svn rev 525637.

Here is the svn status to help with svn add rm for this patch:

M      java/org/apache/jasper/JspCompilationContext.java
M      java/org/apache/jasper/runtime/TagHandlerPool.java
D      java/org/apache/jasper/runtime/AnnotationHelper.java
M      java/org/apache/jasper/servlet/JspServletWrapper.java
A      java/org/apache/jasper/instanceManagement
A      java/org/apache/jasper/instanceManagement/InstanceManager.java
A      java/org/apache/jasper/instanceManagement/DefaultInstanceManager.java
A      java/org/apache/jasper/instanceManagement/InstanceManagerFactory.java
M      java/org/apache/jasper/compiler/Generator.java
M      java/org/apache/catalina/core/ApplicationFilterConfig.java
M      java/org/apache/catalina/core/StandardWrapper.java
M      java/org/apache/catalina/core/StandardContext.java
M      java/org/apache/catalina/core/LocalStrings.properties
M      java/org/apache/catalina/core/mbeans-descriptors.xml
A      java/org/apache/catalina/deploy/Injectable.java
M      java/org/apache/catalina/deploy/ContextEnvironment.java
M      java/org/apache/catalina/deploy/ResourceBase.java
M      java/org/apache/catalina/deploy/MessageDestinationRef.java
A      java/org/apache/catalina/instanceManagement
A      java/org/apache/catalina/instanceManagement/InstanceManager.java
A      java/org/apache/catalina/instanceManagement/AbstractInstanceManager.java
A      java/org/apache/catalina/instanceManagement/DefaultInstanceManager.java
A      java/org/apache/catalina/instanceManagement/InjectionTarget.java
A      java/org/apache/catalina/instanceManagement/InstanceManagerToAnnotationProcessorAdapter.java
M      java/org/apache/catalina/startup/WebRuleSet.java
D      java/org/apache/catalina/util/DefaultAnnotationProcessor.java
X      native/connector
M      build.xml
M      webapps/examples/WEB-INF/web.xml
M      webapps/examples/WEB-INF/classes/LocalStrings.properties
A      webapps/examples/WEB-INF/classes/EnvEntryExample.java

> Proposal for tomcat to change managed object construction/annotation processing
> -------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3010
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3010
>             Project: Geronimo
>          Issue Type: Wish
>      Security Level: public(Regular issues) 
>          Components: Tomcat
>    Affects Versions: 2.0-M4
>            Reporter: David Jencks
>         Assigned To: David Jencks
>         Attachments: GERONIMO-3010-1.patch, GERONIMO-3010-2.patch, GERONIMO-3010-3.patch, GERONIMO-3010-GERONIMO-1.patch
>
>
> I've been working on changing how tomcat might create and destroy "managed objects" (servlets, filters, listeners, and tags) and want a place to attach the work in progress so it is more visible.  I'm not quite ready to propose it to the tomcat community.... thus this jira.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.