[GitHub] [doris] brody715 commented on a diff in pull request #18231: [feature](array_cum_sum) Support array_cum_sum function

["brody715 (via GitHub)" <gi...@apache.org>]

brody715 commented on code in PR #18231:
URL: https://github.com/apache/doris/pull/18231#discussion_r1160643401


##########
be/src/vec/functions/array/function_array_cum_sum.cpp:
##########
@@ -0,0 +1,255 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arrayCumSum.cpp
+// and modified by Doris
+
+#include "vec/columns/column.h"
+#include "vec/columns/column_array.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/data_types/data_type_nullable.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/simple_function_factory.h"
+#include "vec/utils/util.hpp"
+
+namespace doris::vectorized {
+
+// array_cum_sum([1, 2, 3, 4, 5]) -> [1, 3, 6, 10, 15]
+// array_cum_sum([1, NULL, 3, NULL, 5]) -> [1, NULL, 4, NULL, 9]
+class FunctionArrayCumSum : public IFunction {
+public:
+    using NullMapType = PaddedPODArray<UInt8>;
+
+    static constexpr auto name = "array_cum_sum";
+
+    static FunctionPtr create() { return std::make_shared<FunctionArrayCumSum>(); }
+
+    String get_name() const override { return name; }
+
+    bool is_variadic() const override { return false; }
+
+    size_t get_number_of_arguments() const override { return 1; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        DCHECK(is_array(arguments[0]))
+                << "argument for function: " << name << " should be DataTypeArray but it has type "
+                << arguments[0]->get_name() << ".";
+        auto nested_type = assert_cast<const DataTypeArray&>(*(arguments[0])).get_nested_type();
+        bool is_nullable = nested_type->is_nullable();
+
+        auto non_null_nested_type = remove_nullable(nested_type);
+        auto scale = get_decimal_scale(*non_null_nested_type);
+        WhichDataType which(non_null_nested_type);
+        //return type is promoted to prevent result overflow
+        //like: input is int32 ---> return type will be int64
+        DataTypePtr return_type = nullptr;
+
+        // same cast logic as array_sum
+        if (which.is_uint8() || which.is_int8() || which.is_uint16() || which.is_int16() ||
+            which.is_uint32() || which.is_int32() || which.is_int64() || which.is_uint64()) {
+            return_type = std::make_shared<DataTypeInt64>();
+        } else if (which.is_int128()) {
+            return_type = std::make_shared<DataTypeInt128>();
+        } else if (which.is_float32() || which.is_float64()) {
+            return_type = std::make_shared<DataTypeFloat64>();
+        } else if (which.is_decimal128() && !which.is_decimal128i()) {
+            // decimalv2
+            return_type = std::make_shared<DataTypeDecimal<Decimal128>>(
+                    DataTypeDecimal<Decimal128>::max_precision(), scale);
+        } else if (which.is_decimal()) {
+            return_type = std::make_shared<DataTypeDecimal<Decimal128I>>(
+                    DataTypeDecimal<Decimal128I>::max_precision(), scale);
+        }
+        if (return_type) {
+            return std::make_shared<DataTypeArray>(is_nullable ? make_nullable(return_type)
+                                                               : return_type);
+        } else {
+            LOG(FATAL) << "Function of " << name
+                       << " return type get wrong: and input argument is: "
+                       << arguments[0]->get_name();
+        }
+
+        return nullptr;
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+                        const size_t result, size_t input_rows_count) override {
+        auto src_arg = block.get_by_position(arguments[0]);
+        ColumnPtr src_column = src_arg.column->convert_to_full_column_if_const();
+
+        const auto& src_column_array = check_and_get_column<ColumnArray>(src_column.get());
+        if (!src_column_array) {
+            return Status::RuntimeError(
+                    fmt::format("unsupported types for function {}({})", get_name(),
+                                block.get_by_position(arguments[0]).type->get_name()));
+        }
+
+        const auto& src_offsets = src_column_array->get_offsets();
+        const auto* src_nested_column = &src_column_array->get_data();
+        DCHECK(src_nested_column != nullptr);
+
+        // get src nested column
+        auto src_nested_type = assert_cast<const DataTypeArray&>(*src_arg.type).get_nested_type();
+
+        // get null map
+        const NullMapType* src_null_map = nullptr;
+        if (src_nested_column->is_nullable()) {

Review Comment:
   Ok, I remove the check, and modify the source code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org