You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/10 18:46:22 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5236: refactor: correct the implementation of `all_schemas()`

alamb commented on code in PR #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236#discussion_r1103102991


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -177,59 +177,51 @@ impl LogicalPlan {
     /// Get a vector of references to all schemas in every node of the logical plan

Review Comment:
   I think we should update the docstring of this function to reflect its new purpose



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org