You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/29 03:17:06 UTC

[GitHub] [skywalking] hanahmily opened a new pull request #5921: Update istio-controlplane.yaml

hanahmily opened a new pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921


   Remove redundant fields.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   52.83%   -0.01%     
   + Complexity     3493     3491       -2     
   ============================================
     Files           902      902              
     Lines         22648    22648              
     Branches       2185     2185              
   ============================================
   - Hits          11969    11967       -2     
   - Misses         9708     9712       +4     
   + Partials        971      969       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (-66.67%)` | `1.00% <0.00%> (-4.00%)` | |
   | [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `43.83% <0.00%> (-2.74%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.08% <0.00%> (-2.58%)` | `27.00% <0.00%> (-1.00%)` | |
   | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `43.92% <0.00%> (-0.94%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `61.60% <0.00%> (+0.89%)` | `12.00% <0.00%> (+1.00%)` | |
   | [...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `70.71% <0.00%> (+2.20%)` | `24.00% <0.00%> (ø%)` | |
   | [...server/analyzer/provider/meter/process/Window.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvV2luZG93LmphdmE=) | `61.76% <0.00%> (+2.94%)` | `8.00% <0.00%> (+1.00%)` | |
   | ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `1.48%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   51.36%   -1.49%     
   + Complexity     3493     2794     -699     
   ============================================
     Files           902      759     -143     
     Lines         22648    19299    -3349     
     Branches       2185     1806     -379     
   ============================================
   - Hits          11969     9912    -2057     
   + Misses         9708     8667    -1041     
   + Partials        971      720     -251     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
   | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (-66.67%)` | `1.00% <0.00%> (-4.00%)` | |
   | [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `14.63% <0.00%> (-29.27%)` | `8.00% <0.00%> (-5.00%)` | |
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `74.28% <0.00%> (-17.15%)` | `7.00% <0.00%> (-2.00%)` | |
   | ... and [159 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `8.61%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   44.22%   -8.62%     
   + Complexity     3493     2458    -1035     
   ============================================
     Files           902      742     -160     
     Lines         22648    18766    -3882     
     Branches       2185     1758     -427     
   ============================================
   - Hits          11969     8300    -3669     
   - Misses         9708     9820     +112     
   + Partials        971      646     -325     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-95.46%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | ... and [252 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `4.48%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   48.36%   -4.49%     
   + Complexity     3493     2614     -879     
   ============================================
     Files           902      742     -160     
     Lines         22648    18805    -3843     
     Branches       2185     1759     -426     
   ============================================
   - Hits          11969     9095    -2874     
   + Misses         9708     9024     -684     
   + Partials        971      686     -285     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-95.46%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [207 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `1.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   51.30%   -1.55%     
   + Complexity     3493     2793     -700     
   ============================================
     Files           902      759     -143     
     Lines         22648    19299    -3349     
     Branches       2185     1806     -379     
   ============================================
   - Hits          11969     9901    -2068     
   + Misses         9708     8679    -1029     
   + Partials        971      719     -252     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
   | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (-66.67%)` | `1.00% <0.00%> (-4.00%)` | |
   | [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
   | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `14.63% <0.00%> (-29.27%)` | `8.00% <0.00%> (-5.00%)` | |
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `3.00% <0.00%> (-1.00%)` | |
   | ... and [160 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `1.47%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   51.37%   -1.48%     
   + Complexity     3493     2796     -697     
   ============================================
     Files           902      759     -143     
     Lines         22648    19299    -3349     
     Branches       2185     1806     -379     
   ============================================
   - Hits          11969     9914    -2055     
   + Misses         9708     8665    -1043     
   + Partials        971      720     -251     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
   | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (-66.67%)` | `1.00% <0.00%> (-4.00%)` | |
   | [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `14.63% <0.00%> (-29.27%)` | `8.00% <0.00%> (-5.00%)` | |
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `74.28% <0.00%> (-17.15%)` | `7.00% <0.00%> (-2.00%)` | |
   | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | |
   | ... and [158 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] commented on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `22.74%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5921       +/-   ##
   =============================================
   - Coverage     52.84%   30.10%   -22.75%     
   + Complexity     3493     1742     -1751     
   =============================================
     Files           902      742      -160     
     Lines         22648    18551     -4097     
     Branches       2185     1705      -480     
   =============================================
   - Hits          11969     5585     -6384     
   - Misses         9708    12582     +2874     
   + Partials        971      384      -587     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/oap/meter/analyzer/dsl/DownsamplingType.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0Rvd25zYW1wbGluZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [377 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng merged pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `12.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5921       +/-   ##
   =============================================
   - Coverage     52.84%   39.93%   -12.92%     
   + Complexity     3493     2252     -1241     
   =============================================
     Files           902      742      -160     
     Lines         22648    18750     -3898     
     Branches       2185     1756      -429     
   =============================================
   - Hits          11969     7488     -4481     
   - Misses         9708    10677      +969     
   + Partials        971      585      -386     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [277 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   + Coverage     52.84%   52.91%   +0.06%     
   - Complexity     3493     3498       +5     
   ============================================
     Files           902      902              
     Lines         22648    22648              
     Branches       2185     2185              
   ============================================
   + Hits          11969    11984      +15     
   + Misses         9708     9694      -14     
   + Partials        971      970       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
   | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `43.83% <0.00%> (-2.74%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.08% <0.00%> (-2.58%)` | `27.00% <0.00%> (-1.00%)` | |
   | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `43.92% <0.00%> (-0.94%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `61.60% <0.00%> (+0.89%)` | `12.00% <0.00%> (+1.00%)` | |
   | [...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `70.71% <0.00%> (+2.20%)` | `24.00% <0.00%> (ø%)` | |
   | [...server/analyzer/provider/meter/process/Window.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvV2luZG93LmphdmE=) | `61.76% <0.00%> (+2.94%)` | `8.00% <0.00%> (+1.00%)` | |
   | [...nalysis/manual/database/TopNDatabaseStatement.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL1RvcE5EYXRhYmFzZVN0YXRlbWVudC5qYXZh) | `12.50% <0.00%> (+8.33%)` | `2.00% <0.00%> (+2.00%)` | |
   | [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `76.92% <0.00%> (+11.53%)` | `5.00% <0.00%> (+1.00%)` | |
   | ... and [5 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (dfb102c) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `12.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5921       +/-   ##
   =============================================
   - Coverage     51.20%   39.18%   -12.03%     
   + Complexity     3493     2251     -1242     
   =============================================
     Files          1665      759      -906     
     Lines         35718    19181    -16537     
     Branches       3913     1783     -2130     
   =============================================
   - Hits          18290     7516    -10774     
   + Misses        16514    11110     -5404     
   + Partials        914      555      -359     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
   | ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   52.70%   -0.15%     
   + Complexity     3493     3482      -11     
   ============================================
     Files           902      902              
     Lines         22648    22648              
     Branches       2185     2185              
   ============================================
   - Hits          11969    11936      -33     
   - Misses         9708     9744      +36     
   + Partials        971      968       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
   | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (-66.67%)` | `1.00% <0.00%> (-4.00%)` | |
   | [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `43.83% <0.00%> (-2.74%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==) | `52.63% <0.00%> (-2.64%)` | `14.00% <0.00%> (-1.00%)` | |
   | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.08% <0.00%> (-2.58%)` | `27.00% <0.00%> (-1.00%)` | |
   | ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5921: Fix illegal istio-controlplane.yaml

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5921:
URL: https://github.com/apache/skywalking/pull/5921#issuecomment-735337814


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=h1) Report
   > Merging [#5921](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=desc) (4ed5066) into [master](https://codecov.io/gh/apache/skywalking/commit/af19c72a7e441016fd977a07419d0c29fdfc8990?el=desc) (af19c72) will **decrease** coverage by `5.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5921/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5921      +/-   ##
   ============================================
   - Coverage     52.84%   47.57%   -5.28%     
   + Complexity     3493     2593     -900     
   ============================================
     Files           902      742     -160     
     Lines         22648    18805    -3843     
     Branches       2185     1759     -426     
   ============================================
   - Hits          11969     8947    -3022     
   + Misses         9708     9175     -533     
   + Partials        971      683     -288     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-95.46%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [211 more](https://codecov.io/gh/apache/skywalking/pull/5921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=footer). Last update [af19c72...dfb102c](https://codecov.io/gh/apache/skywalking/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org