You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/05 02:23:20 UTC

[GitHub] [flink] zhengcanbin commented on issue #10956: [FLINK-15646][client]Configurable K8s context support.

zhengcanbin commented on issue #10956: [FLINK-15646][client]Configurable K8s context support.
URL: https://github.com/apache/flink/pull/10956#issuecomment-582210778
 
 
   > @zhengcanbin The changes looks really good to me. I just have some minor comments.
   > 
   >     1. The module in the commit title should be `k8s` or `kubernetes`. Maybe "[FLINK-15646][k8s] Make kubernetes context configurable" is better.
   > 
   >     2. Even the abbreviation `k8s` is reasonable in the commit title to leave more characters for other useful information. I suggest to avoid in the code, documentation. This is not forced, and you could leave it as you want.
   > 
   k8s is more shorthand and used commonly in an informal context, sounds reasonable for the commit message.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services