[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #3310: [Feature]use zk own del func

[GitBox <gi...@apache.org>]

dailidong commented on a change in pull request #3310:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3310#discussion_r462901524



##########
File path: script/remove-zk-node.sh
##########
@@ -31,18 +31,20 @@ BIN_DIR=`dirname $0`
 BIN_DIR=`cd "$BIN_DIR"; pwd`
 DOLPHINSCHEDULER_HOME=$BIN_DIR/..
 
+source ${BIN_DIR}/../conf/config/install_config.conf
+
 export JAVA_HOME=$JAVA_HOME
 
 
 export DOLPHINSCHEDULER_CONF_DIR=$DOLPHINSCHEDULER_HOME/conf
 export DOLPHINSCHEDULER_LIB_JARS=$DOLPHINSCHEDULER_HOME/lib/*
 
-export DOLPHINSCHEDULER_OPTS="-server -Xmx1g -Xms1g -Xss512k -XX:+DisableExplicitGC -XX:+UseConcMarkSweepGC -XX:+CMSParallelRemarkEnabled -XX:LargePageSizeInBytes=128m -XX:+UseFastAccessorMethods -XX:+UseCMSInitiatingOccupancyOnly -XX:CMSInitiatingOccupancyFraction=70"
+export DOLPHINSCHEDULER_OPTS="-Xmx1g -Xms1g -Xss512k -XX:+DisableExplicitGC -XX:+UseConcMarkSweepGC -XX:+CMSParallelRemarkEnabled -XX:LargePageSizeInBytes=128m -XX:+UseFastAccessorMethods -XX:+UseCMSInitiatingOccupancyOnly -XX:CMSInitiatingOccupancyFraction=70 -server"

Review comment:
       > I think this is just a cli process. Is it necessary to give such a high memory of -Xmx1g -Xms1g ?
   
   I have removed -server




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org