You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/06/13 20:48:27 UTC

[GitHub] spark issue #20442: [SPARK-23265][ML]Update multi-column error handling logi...

Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/20442
  
    @huaxingao  Thanks for this follow-up!  I realized that https://github.com/apache/spark/pull/19715 introduced a breaking change which we missed in Spark 2.3 QA:  In Spark 2.2, a user could set inputCol but not set outputCol (since outputCol has a default value).  The new check causes such user code to start failing in Spark 2.3.
    
    Since you're already working on this follow-up, would you mind adding a unit test which checks this?  (Setting inputCol but not outputCol, and making sure that works.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org