[GitHub] [pulsar] tjiuming commented on a diff in pull request #19287: [branch-2.9][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed

["tjiuming (via GitHub)" <gi...@apache.org>]

tjiuming commented on code in PR #19287:
URL: https://github.com/apache/pulsar/pull/19287#discussion_r1092775640


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1400,6 +1406,12 @@ public void openLedgerComplete(ManagedLedger ledger, Object ctx) {
                                             "Replication or dedup check failed."
                                                     + " Removing topic from topics list {}, {}",
                                             topic, ex);
+                                    persistentTopic.getTransactionBuffer()

Review Comment:
   Great catch!
   it makes sense, in line `1395`, it seems like checking create topic timeout, it's also need to close transaction buffer.
   I'll create another PR to add the logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org