svn commit: r1365506 - /felix/trunk/framework/src/main/java/org/apache/felix/framework/BundleRevisionImpl.java

[gn...@apache.org]

Author: gnodet
Date: Wed Jul 25 09:52:20 2012
New Revision: 1365506

URL: http://svn.apache.org/viewvc?rev=1365506&view=rev
Log:
[FELIX-3609] Optimization: cache BundleRevision's types

Modified:
    felix/trunk/framework/src/main/java/org/apache/felix/framework/BundleRevisionImpl.java

Modified: felix/trunk/framework/src/main/java/org/apache/felix/framework/BundleRevisionImpl.java
URL: http://svn.apache.org/viewvc/felix/trunk/framework/src/main/java/org/apache/felix/framework/BundleRevisionImpl.java?rev=1365506&r1=1365505&r2=1365506&view=diff
==============================================================================
--- felix/trunk/framework/src/main/java/org/apache/felix/framework/BundleRevisionImpl.java (original)
+++ felix/trunk/framework/src/main/java/org/apache/felix/framework/BundleRevisionImpl.java Wed Jul 25 09:52:20 2012
@@ -56,6 +56,7 @@ public class BundleRevisionImpl implemen
 
     private final String m_manifestVersion;
     private final boolean m_isExtension;
+    private final boolean m_isFragment;
     private final String m_symbolicName;
     private final Version m_version;
 
@@ -95,6 +96,7 @@ public class BundleRevisionImpl implemen
         m_manifestVersion = null;
         m_symbolicName = null;
         m_isExtension = false;
+        m_isFragment = false;
         m_version = null;
         m_declaredCaps = Collections.EMPTY_LIST;
         m_declaredReqs = Collections.EMPTY_LIST;
@@ -136,6 +138,7 @@ public class BundleRevisionImpl implemen
             : ManifestParser.parseDelimitedString(mp.getActivationIncludeDirective(), ",");
         m_symbolicName = mp.getSymbolicName();
         m_isExtension = mp.isExtension();
+        m_isFragment = m_headerMap.containsKey(Constants.FRAGMENT_HOST);
     }
 
     static SecureAction getSecureAction()
@@ -247,12 +250,8 @@ public class BundleRevisionImpl implemen
 
     public int getTypes()
     {
-        if ((getManifestVersion() == "2")
-            && getHeaders().containsKey(Constants.FRAGMENT_HOST))
-        {
-            return BundleRevision.TYPE_FRAGMENT;
-        }
-        return 0;
+        return getManifestVersion() == "2" && m_isFragment
+                ? BundleRevision.TYPE_FRAGMENT : 0;
     }
 
     public BundleWiring getWiring()