You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/18 03:48:51 UTC
Review Request 22714: Added a test to verify that frameworks with equal
share get equal number of allocations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22714/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-1187
https://issues.apache.org/jira/browse/MESOS-1187
Repository: mesos-git
Description
-------
I wrote this test because to see if I can repro the issue in MESOS-1187 (there's also an existing TODO). Unfortunately couldn't repro the behavior, but this would be a good regression test to have.
Diffs
-----
src/tests/allocator_tests.cpp 7ad496437cec6238f208225a012030b7f3c8fe84
src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4
Diff: https://reviews.apache.org/r/22714/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 22714: Added a test to verify that frameworks with equal
share get equal number of allocations.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22714/#review46078
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22714]
All tests passed.
- Mesos ReviewBot
On June 18, 2014, 1:48 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22714/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 1:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I wrote this test because to see if I can repro the issue in MESOS-1187 (there's also an existing TODO). Unfortunately couldn't repro the behavior, but this would be a good regression test to have.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 7ad496437cec6238f208225a012030b7f3c8fe84
> src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4
>
> Diff: https://reviews.apache.org/r/22714/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22714: Added a test to verify that frameworks with equal
share get equal number of allocations.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22714/
-----------------------------------------------------------
(Updated June 24, 2014, 7:22 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
updated bug.
Bugs: MESOS-1505
https://issues.apache.org/jira/browse/MESOS-1505
Repository: mesos-git
Description
-------
I wrote this test because to see if I can repro the issue in MESOS-1187 (there's also an existing TODO). Unfortunately couldn't repro the behavior, but this would be a good regression test to have.
Diffs
-----
src/tests/allocator_tests.cpp 7ad496437cec6238f208225a012030b7f3c8fe84
src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4
Diff: https://reviews.apache.org/r/22714/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 22714: Added a test to verify that frameworks with equal
share get equal number of allocations.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22714/#review46565
-----------------------------------------------------------
Ship it!
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/22714/#comment82011>
where is the closing paren? :)
- Ben Mahler
On June 18, 2014, 1:48 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22714/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 1:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I wrote this test because to see if I can repro the issue in MESOS-1187 (there's also an existing TODO). Unfortunately couldn't repro the behavior, but this would be a good regression test to have.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 7ad496437cec6238f208225a012030b7f3c8fe84
> src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4
>
> Diff: https://reviews.apache.org/r/22714/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>