You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/27 11:21:56 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
AngersZhuuuu opened a new pull request #34400:
URL: https://github.com/apache/spark/pull/34400
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953233504
**[Test build #144668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144668/testReport)** for PR 34400 at commit [`9f000b8`](https://github.com/apache/spark/commit/9f000b84fae0c5d3fe0cf7167c7e9bf7ed50ac2c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953449718
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144686/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737521796
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -379,20 +392,26 @@ private[client] class Shim_v0_12 extends Shim with Logging {
database: String,
tableName: String,
parts: Seq[CatalogTablePartition],
- ignoreIfExists: Boolean): Unit = {
+ ignoreIfExists: Boolean): Unit = withHiveCall {
val table = hive.getTable(database, tableName)
parts.foreach { s =>
val location = s.storage.locationUri.map(
uri => new Path(table.getPath, new Path(uri))).orNull
val params = if (s.parameters.nonEmpty) s.parameters.asJava else null
val spec = s.spec.asJava
+ // Since Spark don't know if it will throw exception when iterate all parts.
+ // So Spark increase the hive client call metrics here when invoke getTable().
+ HiveCatalogMetrics.incrementHiveClientCalls(1)
if (hive.getPartition(table, spec, false) != null && ignoreIfExists) {
Review comment:
shall we call the shim method here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953659314
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953597739
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r738044596
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -405,6 +404,7 @@ private[hive] class HiveClientImpl(
private def getRawTablesByName(dbName: String, tableNames: Seq[String]): Seq[HiveTable] = {
try {
+ shim.recordHiveCall
msClient.getTableObjectsByName(dbName, tableNames.asJava).asScala
Review comment:
why don't this go into the shim?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953565943
**[Test build #144702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144702/testReport)** for PR 34400 at commit [`bad337e`](https://github.com/apache/spark/commit/bad337ebdaa27c14c80a4f50c4f874de8fbbbebb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953177329
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49137/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952968242
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49127/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737528352
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -244,6 +245,18 @@ private[client] sealed abstract class Shim {
protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
klass.getMethod(name, args: _*)
}
+
+ protected def withHiveCall[A](f: => A): A = {
+ withHiveCall(1)(f)
+ }
+
+ protected def withHiveCall[A](numCalls: Int = 1)(f: => A): A = {
+ try {
+ f
+ } finally {
+ HiveCatalogMetrics.incrementHiveClientCalls(numCalls)
Review comment:
seems simpler to do
```
HiveCatalogMetrics.incrementHiveClientCalls(numCalls)
f
```
since `incrementHiveClientCalls` won't fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953464274
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49155/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953132752
**[Test build #144668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144668/testReport)** for PR 34400 at commit [`9f000b8`](https://github.com/apache/spark/commit/9f000b84fae0c5d3fe0cf7167c7e9bf7ed50ac2c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953449181
**[Test build #144686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144686/testReport)** for PR 34400 at commit [`80c7460`](https://github.com/apache/spark/commit/80c74606bf84c72ea790a7e0203b00c5913eb951).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737663522
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -259,7 +272,7 @@ private[client] class Shim_v0_12 extends Shim with Logging {
msc
}
- override def getMSC(hive: Hive): IMetaStoreClient = {
+ override def getMSC(hive: Hive): IMetaStoreClient = withHiveCall {
Review comment:
> does this send an RPC request?
Since the only call on this have a client call, now should be clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r738046452
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -405,6 +404,7 @@ private[hive] class HiveClientImpl(
private def getRawTablesByName(dbName: String, tableNames: Seq[String]): Seq[HiveTable] = {
try {
+ shim.recordHiveCall
msClient.getTableObjectsByName(dbName, tableNames.asJava).asScala
Review comment:
> why don't this go into the shim?
msClient is from shim.getMSC
```
private def msClient: IMetaStoreClient = {
shim.getMSC(client)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r738058954
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -380,19 +385,22 @@ private[client] class Shim_v0_12 extends Shim with Logging {
tableName: String,
parts: Seq[CatalogTablePartition],
ignoreIfExists: Boolean): Unit = {
+ recordHiveCall
Review comment:
this has side effects. Let's call it with brackets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952819420
**[Test build #144656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144656/testReport)** for PR 34400 at commit [`c13c4e0`](https://github.com/apache/spark/commit/c13c4e0290adcbece634d49336928922d4405d4c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953705223
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144702/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952929679
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144656/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952968242
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49127/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952953127
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49127/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953652378
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953565943
**[Test build #144702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144702/testReport)** for PR 34400 at commit [`bad337e`](https://github.com/apache/spark/commit/bad337ebdaa27c14c80a4f50c4f874de8fbbbebb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r738070919
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -244,6 +245,10 @@ private[client] sealed abstract class Shim {
protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
klass.getMethod(name, args: _*)
}
+
+ def recordHiveCall(): Unit = {
Review comment:
let's add some comments. It should be called before a hive client call is made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952860103
**[Test build #144657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144657/testReport)** for PR 34400 at commit [`4b9655d`](https://github.com/apache/spark/commit/4b9655d77a2cc10abf02c1602396b2646fcbf63c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952977498
**[Test build #144657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144657/testReport)** for PR 34400 at commit [`4b9655d`](https://github.com/apache/spark/commit/4b9655d77a2cc10abf02c1602396b2646fcbf63c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953455023
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49155/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34400:
URL: https://github.com/apache/spark/pull/34400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952909772
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953449181
**[Test build #144686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144686/testReport)** for PR 34400 at commit [`80c7460`](https://github.com/apache/spark/commit/80c74606bf84c72ea790a7e0203b00c5913eb951).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953464399
**[Test build #144687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144687/testReport)** for PR 34400 at commit [`ec74fb1`](https://github.com/apache/spark/commit/ec74fb1294b1d1331e523601350c15c0e749cc8f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953507556
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49159/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952929679
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144656/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953464274
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49155/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952819420
**[Test build #144656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144656/testReport)** for PR 34400 at commit [`c13c4e0`](https://github.com/apache/spark/commit/c13c4e0290adcbece634d49336928922d4405d4c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953234877
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144668/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953234877
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144668/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r738070118
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -380,19 +385,22 @@ private[client] class Shim_v0_12 extends Shim with Logging {
tableName: String,
parts: Seq[CatalogTablePartition],
ignoreIfExists: Boolean): Unit = {
+ recordHiveCall
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737663719
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -244,6 +245,18 @@ private[client] sealed abstract class Shim {
protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
klass.getMethod(name, args: _*)
}
+
+ protected def withHiveCall[A](f: => A): A = {
+ withHiveCall(1)(f)
+ }
+
+ protected def withHiveCall[A](numCalls: Int = 1)(f: => A): A = {
+ try {
+ f
+ } finally {
+ HiveCatalogMetrics.incrementHiveClientCalls(numCalls)
Review comment:
> Actually, maybe it's clearer to do
>
> ```
> def recordHiveCall() {
> HiveCatalogMetrics.incrementHiveClientCalls(1)
> }
> ```
>
> And then call this method before any `hive.xxx` calls.
updated, but why not just use
```
HiveCatalogMetrics.incrementHiveClientCalls(1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952860103
**[Test build #144657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144657/testReport)** for PR 34400 at commit [`4b9655d`](https://github.com/apache/spark/commit/4b9655d77a2cc10abf02c1602396b2646fcbf63c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953224384
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49137/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952827228
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953449718
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144686/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953482733
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49159/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953699675
**[Test build #144702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144702/testReport)** for PR 34400 at commit [`bad337e`](https://github.com/apache/spark/commit/bad337ebdaa27c14c80a4f50c4f874de8fbbbebb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953508179
**[Test build #144687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144687/testReport)** for PR 34400 at commit [`ec74fb1`](https://github.com/apache/spark/commit/ec74fb1294b1d1331e523601350c15c0e749cc8f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-954575250
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953229395
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49137/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953132752
**[Test build #144668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144668/testReport)** for PR 34400 at commit [`9f000b8`](https://github.com/apache/spark/commit/9f000b84fae0c5d3fe0cf7167c7e9bf7ed50ac2c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952927919
**[Test build #144656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144656/testReport)** for PR 34400 at commit [`c13c4e0`](https://github.com/apache/spark/commit/c13c4e0290adcbece634d49336928922d4405d4c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952910197
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952979214
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144657/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953508989
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144687/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953508989
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144687/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953464399
**[Test build #144687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144687/testReport)** for PR 34400 at commit [`ec74fb1`](https://github.com/apache/spark/commit/ec74fb1294b1d1331e523601350c15c0e749cc8f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953498262
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49159/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952860868
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r738078062
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -244,6 +245,10 @@ private[client] sealed abstract class Shim {
protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
klass.getMethod(name, args: _*)
}
+
+ def recordHiveCall(): Unit = {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953229395
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49137/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953659314
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953507556
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49159/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953449696
**[Test build #144686 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144686/testReport)** for PR 34400 at commit [`80c7460`](https://github.com/apache/spark/commit/80c74606bf84c72ea790a7e0203b00c5913eb951).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737531292
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -244,6 +245,18 @@ private[client] sealed abstract class Shim {
protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
klass.getMethod(name, args: _*)
}
+
+ protected def withHiveCall[A](f: => A): A = {
+ withHiveCall(1)(f)
+ }
+
+ protected def withHiveCall[A](numCalls: Int = 1)(f: => A): A = {
+ try {
+ f
+ } finally {
+ HiveCatalogMetrics.incrementHiveClientCalls(numCalls)
Review comment:
Actually, maybe it's clearer to do
```
def recordHiveCall() {
HiveCatalogMetrics.incrementHiveClientCalls(numCalls)
}
```
And then call this method before any `hive.xxx` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737531292
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -244,6 +245,18 @@ private[client] sealed abstract class Shim {
protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
klass.getMethod(name, args: _*)
}
+
+ protected def withHiveCall[A](f: => A): A = {
+ withHiveCall(1)(f)
+ }
+
+ protected def withHiveCall[A](numCalls: Int = 1)(f: => A): A = {
+ try {
+ f
+ } finally {
+ HiveCatalogMetrics.incrementHiveClientCalls(numCalls)
Review comment:
Actually, maybe it's clearer to do
```
def recordHiveCall() {
HiveCatalogMetrics.incrementHiveClientCalls(1)
}
```
And then call this method before any `hive.xxx` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952979214
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144657/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737529952
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -259,7 +272,7 @@ private[client] class Shim_v0_12 extends Shim with Logging {
msc
}
- override def getMSC(hive: Hive): IMetaStoreClient = {
+ override def getMSC(hive: Hive): IMetaStoreClient = withHiveCall {
Review comment:
does this send an RPC request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-953705223
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144702/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952910197
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34400:
URL: https://github.com/apache/spark/pull/34400#issuecomment-952896494
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49127/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org