[GitHub] [superset] michellethomas commented on pull request #13086: fix: accept null groupby in form data for timeseries table viz

[GitBox <gi...@apache.org>]

michellethomas commented on pull request #13086:
URL: https://github.com/apache/superset/pull/13086#issuecomment-778443776


   That's a good question @john-bodley I made the changes in the code because they were pretty simple, not complicated logic to handle lots of nuances but just simple null handling (which in the case of the code in viz.py needs to happen anyways in some form). I don't think that this case needs to be handled in the code forever, eventually old charts will likely become obsolete. I think in general a db migration would be better to migrate old formats, but since this fix is simple, a db migration to resolve only a fraction of charts of this specific viz type seemed a little overkill. But I'm fine to do that if that's the preferred way. Do you know who else would be good to decide whether a db migration is preferred?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org