[GitHub] [maven-release] slawekjaranowski commented on a diff in pull request #151: [MRELEASE-1104] fix stage goal when having both arguments and stagingRepository

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #151:
URL: https://github.com/apache/maven-release/pull/151#discussion_r978837435


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java:
##########
@@ -110,6 +110,9 @@ public void executeGoals( File workingDirectory, List<String> goals, ReleaseEnvi
 
             cl.setWorkingDirectory( workingDirectory.getAbsolutePath() );
 
+            // FIX for MRELEASE-1105
+            //cl.addEnvironment( "MAVEN_DEBUG_OPTS", "" );
+

Review Comment:
   probably for next PR - unneeded comments



##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -72,6 +72,8 @@ public void executeGoals( File workingDirectory, List<String> goals, ReleaseEnvi
         InvocationRequest req = new DefaultInvocationRequest()
                 .setDebug( getLogger().isDebugEnabled() )
                 .setBaseDirectory( workingDirectory )
+                // fix for MRELEASE-1105
+                //.addShellEnvironment( "MAVEN_DEBUG_OPTS", "" )

Review Comment:
   probably for next PR - unneeded comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org