You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/20 16:52:32 UTC

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742:
URL: https://github.com/apache/flink/pull/21742#discussion_r1082817072


##########
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java:
##########
@@ -100,6 +100,7 @@ public final void stop() throws Exception {
             if (!running) {
                 return;
             }
+            leaderContender.revokeLeadership();

Review Comment:
   @wangyang0918 Was there a rationale to omit the revoking of the leadership when stopping the service? We even added a dedicated test for that in `DefaultLeaderElectionServiceTest`. :thinking: 
   
   To help gettin back the memory: The commit belongs to PR #13644 (FLINK-19542).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org