You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/17 02:48:37 UTC

[GitHub] [calcite] liyafan82 commented on a change in pull request #1992: [CALCITE-3963] Maintains logical properties at RelSet (equivalent gro…

liyafan82 commented on a change in pull request #1992:
URL: https://github.com/apache/calcite/pull/1992#discussion_r441249975



##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java
##########
@@ -211,6 +219,7 @@ public RelSubset add(RelNode rel) {
     final RelSubset subset = getOrCreateSubset(
         rel.getCluster(), traitSet, rel.isEnforcer());
     subset.add(rel);
+    checkAndUpdateOriginalRel(rel);

Review comment:
       This call seems duplicate with the call in addInternal, as subset.add(rel) will call addInternal?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org