You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/08 21:30:57 UTC

[GitHub] brooklyn-server pull request #418: Adds ConfigYamlTest.testConfigAtTopLevel

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/418

    Adds ConfigYamlTest.testConfigAtTopLevel

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server test/config-in-yaml-at-topLevel

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #418
    
----
commit 76a461581aeac1ce627909e039e7a614d31162d7
Author: Aled Sage <al...@gmail.com>
Date:   2016-11-08T21:29:18Z

    Adds ConfigYamlTest.testConfigAtTopLevel

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #418: Adds ConfigYamlTest.testConfigAtTopLevel

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/418
  
    Merging this now (even though not reviewed), as it only adds tests.
    @tbouron you might be interested in taking a look - it was motivated by something you said, about whether we needed to use `@SetFromFlag` on config fields.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #418: Adds ConfigYamlTest.testConfigAtTopLevel

Posted by tbouron <gi...@git.apache.org>.

Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-server/pull/418
  
    Thanks @aledsage! Indeed, it's great to have this test, it confirm what you said, i.e we don't need to mark a ConfigKey with `@SetConfigFlag` annotation to be able to use it as top level config


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #418: Adds ConfigYamlTest.testConfigAtTopLevel

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/418


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---