You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/04 18:44:01 UTC

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41424/#review112602
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 22, 2015, 8:44 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41424/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 8:44 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3909
>     https://issues.apache.org/jira/browse/MESOS-3909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Stout JSON API depends on picojson.h, so we need to install it
> to be able to build Mesos modules outside the Mesos source tree.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 04d0fa324bf6eab98a51fc08298b9da2992d29d1 
> 
> Diff: https://reviews.apache.org/r/41424/diff/
> 
> 
> Testing
> -------
> 
> Build an external module that implicitly depends on picojson.h
> 
> 
> Thanks,
> 
> James Peach
> 
>