You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/06 04:02:27 UTC

[GitHub] [pulsar] liudezhi2098 opened a new pull request #7458: fix bookieMetadataServiceUri acquisition method

liudezhi2098 opened a new pull request #7458:
URL: https://github.com/apache/pulsar/pull/7458


   Master Issue: #7457
   ## Motivation
   
   when zookeeperServers and configurationStoreServers is different , the bookieMetadataServiceUri is incorrectly obtained 
   
   ## Modifications
   BrokerService
   ```java
       public static String bookieMetadataServiceUri(ServiceConfiguration config) {
           ClientConfiguration bkConf = new ClientConfiguration();
           // init bookkeeper metadata service uri
           String metadataServiceUri = null;
           try {
               String zkServers = config.getConfigurationStoreServers();
               bkConf.setZkServers(zkServers);
               metadataServiceUri = bkConf.getMetadataServiceUri();
           } catch (ConfigurationException e) {
               LOG.error("Failed to get bookkeeper metadata service uri", e);
           }
           return metadataServiceUri;
       }
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #7458: fix bookieMetadataServiceUri acquisition method

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7458:
URL: https://github.com/apache/pulsar/pull/7458#issuecomment-654067170


   @liudezhi2098 We never store bookkeeper metadata in the configuration store. The bookkeeper metadata is always in the local zookeeper cluster.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] liudezhi2098 closed pull request #7458: fix bookieMetadataServiceUri acquisition method

Posted by GitBox <gi...@apache.org>.
liudezhi2098 closed pull request #7458:
URL: https://github.com/apache/pulsar/pull/7458


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org