You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/25 07:55:49 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43092: [SPARK-45305][TESTS] Remove JDK 8 workaround added TreeNodeSuite
HyukjinKwon commented on code in PR #43092:
URL: https://github.com/apache/spark/pull/43092#discussion_r1335517628
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala:
##########
@@ -871,28 +871,6 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
}
}
- test("SPARK-32999: TreeNode.nodeName should not throw malformed class name error") {
- val testTriggersExpectedError = try {
- classOf[MalformedClassObject.MalformedNameExpression].getSimpleName
Review Comment:
you're awesome 👍
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala:
##########
@@ -871,28 +871,6 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
}
}
- test("SPARK-32999: TreeNode.nodeName should not throw malformed class name error") {
- val testTriggersExpectedError = try {
- classOf[MalformedClassObject.MalformedNameExpression].getSimpleName
Review Comment:
you're awesome 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org