[GitHub] john-bodley commented on a change in pull request #5178: [sql] Correct SQL parameter formatting

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #5178: [sql] Correct SQL parameter formatting 
URL: https://github.com/apache/incubator-superset/pull/5178#discussion_r194939505
 
 

 ##########
 File path: superset/models/core.py
 ##########
 @@ -706,15 +703,36 @@ def needs_conversion(df_series):
                 return True
             return False
 
-        for k, v in df.dtypes.items():
-            if v.type == numpy.object_ and needs_conversion(df[k]):
-                df[k] = df[k].apply(utils.json_dumps_w_dates)
-        return df
+        with closing(engine.raw_connection()) as conn:
+            with closing(conn.cursor()) as cursor:
+                for sql in sqls:
+                    cursor.execute(sql, **self.db_engine_spec.cursor_execute_kwargs)
 
 Review comment:
   @mistercrunch my one concern is for Hive and whether running async=True (as defined by the engine spec) makes sense here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org