[GitHub] [airflow] dstandish commented on a change in pull request #21273: Add test to run DB downgrade in the CI

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #21273:
URL: https://github.com/apache/airflow/pull/21273#discussion_r807057637



##########
File path: airflow/migrations/versions/5e3ec427fdd3_increase_length_of_email_and_username.py
##########
@@ -46,9 +46,11 @@ def upgrade():
 
 def downgrade():
     """Revert length of email from 256 to 64 characters"""

Review comment:
       question ... 
   what happens when this migration fails?  e.g. what if a user has been added whose username is greater than 64 characters?
   
   perhaps once the length has been increased, we should not reduce it, even in a downgrade.  because i'm thinking that (1) leaving it as is isn't going to hurt anyone -- i.e. it's not a material issue -- and (2) changing it has a possibility of breaking the downgrade.
   
   perhaps downgrades should be "pragmatic" in this way?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org