You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2021/07/31 21:20:00 UTC

[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation

     [ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Semb Wever updated CASSANDRA-14085:
-------------------------------------------
    Fix Version/s:     (was: 3.11.x)
                       (was: 4.x)
                       (was: 3.0.x)
                   4.0.1
                   3.11.12
                   3.0.26

> Excessive update of ReadLatency metric in digest calculation
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-14085
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14085
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core, Observability/Metrics
>            Reporter: Andrew Whang
>            Assignee: Andrew Whang
>            Priority: Low
>             Fix For: 3.0.26, 3.11.12, 4.0.1, 4.1
>
>
> We noticed an increase in read latency after upgrading to 3.x, specifically for requests with CL>ONE. It turns out the read latency metric is being doubly updated for digest calculations. This code (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) makes an improper copy of an iterator that's wrapped by MetricRecording, whose onClose() records the latency of the execution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org