You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/04 02:19:45 UTC
[GitHub] [servicecomb-java-chassis] heyile opened a new pull request #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
heyile opened a new pull request #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617
…me time, it will throw null pointer exception
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617#issuecomment-594308379
[](https://coveralls.io/builds/29115013)
Coverage increased (+0.02%) to 86.414% when pulling **6475bac20d0ab5735f6d495d9a6107b505179412 on heyile:heyileRqValue** into **fbf7cae39b5a77ab594883508e627485a1863bd4 on apache:1.3.x**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617#issuecomment-594308379
[](https://coveralls.io/builds/29379307)
Coverage increased (+0.03%) to 86.42% when pulling **459e547aecfd92c4fd8b46a9081ab31fa516a759 on heyile:heyileRqValue** into **fbf7cae39b5a77ab594883508e627485a1863bd4 on apache:1.3.x**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile commented on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
heyile commented on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617#issuecomment-599425666
> It's better to add some integration tests for this.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617#issuecomment-599294744
It's better to add some integration tests for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617#issuecomment-594308379
[](https://coveralls.io/builds/29379271)
Coverage increased (+0.02%) to 86.414% when pulling **459e547aecfd92c4fd8b46a9081ab31fa516a759 on heyile:heyileRqValue** into **fbf7cae39b5a77ab594883508e627485a1863bd4 on apache:1.3.x**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1617: [SCB-1793] use @RequestHeader(value ="xxx") and aggregatedParam at sa…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1617#issuecomment-594308379
[](https://coveralls.io/builds/29379252)
Coverage increased (+0.04%) to 86.426% when pulling **459e547aecfd92c4fd8b46a9081ab31fa516a759 on heyile:heyileRqValue** into **fbf7cae39b5a77ab594883508e627485a1863bd4 on apache:1.3.x**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services