You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tomasz Wysocki (JIRA)" <ji...@codehaus.org> on 2008/07/25 13:40:26 UTC
[jira] Created: (MNG-3682) Ininite loop in MavenMetaDataSource
Ininite loop in MavenMetaDataSource
-----------------------------------
Key: MNG-3682
URL: http://jira.codehaus.org/browse/MNG-3682
Project: Maven 2
Issue Type: Bug
Affects Versions: 2.x
Reporter: Tomasz Wysocki
Priority: Minor
The do-while loop in MavenMetadataSource can run forever when ProjectBuildingException occurs after project relocation.
Suggested fix:
Change
catch ( ProjectBuildingException e )
{
handleInvalidOrMissingMavenPOM( artifact, e );
}
to
catch ( ProjectBuildingException e )
{
handleInvalidOrMissingMavenPOM( artifact, e );
project = null;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3682) Ininite loop in MavenMetaDataSource
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MNG-3682:
----------------------------
Fix Version/s: 2.0.10
need to review the status of this issue before we push forward on the RCs, since I think you're referring to code that I added for the 2.0.10 release process (then subsequently it got ported to 2.0.x main branch and 2.1/trunk).
> Ininite loop in MavenMetaDataSource
> -----------------------------------
>
> Key: MNG-3682
> URL: http://jira.codehaus.org/browse/MNG-3682
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.x
> Reporter: Tomasz Wysocki
> Priority: Minor
> Fix For: 2.0.10
>
>
> The do-while loop in MavenMetadataSource can run forever when ProjectBuildingException occurs after project relocation.
> Suggested fix:
> Change
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> }
> to
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> project = null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3682) Ininite loop in MavenMetaDataSource
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143157#action_143157 ]
John Casey commented on MNG-3682:
---------------------------------
can you be more specific about where you saw this error? If it's happening in 2.0.10-RC2, then it needs to be addressed.
Also, do you have a failing test case we could use as a basis for an integration test? This would make it much easier to be sure we got it fixed.
> Ininite loop in MavenMetaDataSource
> -----------------------------------
>
> Key: MNG-3682
> URL: http://jira.codehaus.org/browse/MNG-3682
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.x
> Reporter: Tomasz Wysocki
> Priority: Minor
>
> The do-while loop in MavenMetadataSource can run forever when ProjectBuildingException occurs after project relocation.
> Suggested fix:
> Change
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> }
> to
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> project = null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3682) Ininite loop in MavenMetaDataSource
Posted by "Tomasz Wysocki (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143174#action_143174 ]
Tomasz Wysocki commented on MNG-3682:
-------------------------------------
Yes, this was observed on a trunk. Actually I've spotted it using m2eclipse which uses some 2.1-SNAPSHOT code.
> Ininite loop in MavenMetaDataSource
> -----------------------------------
>
> Key: MNG-3682
> URL: http://jira.codehaus.org/browse/MNG-3682
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.x
> Reporter: Tomasz Wysocki
> Assignee: John Casey
> Priority: Minor
> Fix For: 2.1-alpha-1
>
>
> The do-while loop in MavenMetadataSource can run forever when ProjectBuildingException occurs after project relocation.
> Suggested fix:
> Change
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> }
> to
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> project = null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3682) Ininite loop in MavenMetaDataSource
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MNG-3682.
---------------------------
Assignee: John Casey
Resolution: Fixed
Fix Version/s: (was: 2.0.10)
2.1-alpha-1
investigated 2.0.10-RC branch, and this code doesn't apply there. Fixed on trunk (2.1-alpha-1 will be where this first appears).
Thanks for the help.
> Ininite loop in MavenMetaDataSource
> -----------------------------------
>
> Key: MNG-3682
> URL: http://jira.codehaus.org/browse/MNG-3682
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.x
> Reporter: Tomasz Wysocki
> Assignee: John Casey
> Priority: Minor
> Fix For: 2.1-alpha-1
>
>
> The do-while loop in MavenMetadataSource can run forever when ProjectBuildingException occurs after project relocation.
> Suggested fix:
> Change
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> }
> to
> catch ( ProjectBuildingException e )
> {
> handleInvalidOrMissingMavenPOM( artifact, e );
> project = null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira