[GitHub] mistercrunch commented on a change in pull request #4005: [BUGFIX]: Java scripts max int is 2^53 - 1, longs are bigger

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4005: [BUGFIX]: Java scripts max int is 2^53 - 1, longs are bigger
URL: https://github.com/apache/incubator-superset/pull/4005#discussion_r155028688
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -935,7 +946,10 @@ def to_series(self, df, classed='', title_suffix=''):
             ys = series[name]
             if df[name].dtype.kind not in 'biufc':
                 continue
-            series_title = name
+            if isinstance(name, (list, tuple)):
+                series_title = [str(title) for title in name]
 
 Review comment:
   does that affect bar chart sorting?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services