You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/11 15:04:41 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #8025: [bugfix] Fix deck_polygon metric bug and update examples chart

villebro opened a new pull request #8025: [bugfix] Fix deck_polygon metric bug and update examples chart
URL: https://github.com/apache/incubator-superset/pull/8025
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   
   ### SUMMARY
   Previously `deck_polygon` elevation only worked with old school metrics or fixed values. PR #7924 added support for ad-hoc metrics, but broke support for old-school metrics. This PR makes all elevation types work (ad-hoc metric, oldschool metric and fixed), and adds a few bells and whistles to the example chart, namely coloring based on total population + legend formatting as introduced in #7951 .
   
   ### BEFORE
   ![image](https://user-images.githubusercontent.com/33317356/62835528-2da33b80-bc62-11e9-9b53-dcef44f9a89c.png)
   
   ### AFTER
   ![image](https://user-images.githubusercontent.com/33317356/62835491-e7e67300-bc61-11e9-94e0-0b9e996851c7.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### REVIEWERS
   @thunter009 @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org