You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Travis Crawford (JIRA)" <ji...@apache.org> on 2012/04/27 02:08:58 UTC
[jira] [Created] (HIVE-2983) Hive ant targets for publishing maven
artifacts can be simplified
Travis Crawford created HIVE-2983:
-------------------------------------
Summary: Hive ant targets for publishing maven artifacts can be simplified
Key: HIVE-2983
URL: https://issues.apache.org/jira/browse/HIVE-2983
Project: Hive
Issue Type: Improvement
Reporter: Travis Crawford
Assignee: Travis Crawford
Priority: Minor
Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the {{iterate}} macro that simplifies other tasks cannot be used in this context.
Hive already uses the {{for}} task from ant-contrib, which works great here. {{build.xml}} can be simplified by using the for task when preparing maven artifacts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2983) Hive ant targets for publishing
maven artifacts can be simplified
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502530#comment-13502530 ]
Ashutosh Chauhan commented on HIVE-2983:
----------------------------------------
Patch looks good. Couple of questions:
* I don't see a reason to publish ant-tasks jar, we can take that out of the list.
* I don't get why you have special handled exec?
> Hive ant targets for publishing maven artifacts can be simplified
> -----------------------------------------------------------------
>
> Key: HIVE-2983
> URL: https://issues.apache.org/jira/browse/HIVE-2983
> Project: Hive
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2983.D2961.1.patch
>
>
> Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the {{iterate}} macro that simplifies other tasks cannot be used in this context.
> Hive already uses the {{for}} task from ant-contrib, which works great here. {{build.xml}} can be simplified by using the for task when preparing maven artifacts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2983) Hive ant targets for publishing maven
artifacts can be simplified
Posted by "Travis Crawford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Travis Crawford updated HIVE-2983:
----------------------------------
Status: Patch Available (was: Open)
> Hive ant targets for publishing maven artifacts can be simplified
> -----------------------------------------------------------------
>
> Key: HIVE-2983
> URL: https://issues.apache.org/jira/browse/HIVE-2983
> Project: Hive
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Priority: Minor
> Attachments: HIVE-2983.D2961.1.patch
>
>
> Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the {{iterate}} macro that simplifies other tasks cannot be used in this context.
> Hive already uses the {{for}} task from ant-contrib, which works great here. {{build.xml}} can be simplified by using the for task when preparing maven artifacts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2983) Hive ant targets for publishing maven
artifacts can be simplified
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2983:
------------------------------
Attachment: HIVE-2983.D2961.1.patch
travis requested code review of "HIVE-2983 [jira] Hive ant targets for publishing maven artifacts can be simplified".
Reviewers: JIRA
Simplify some maven-related ant tasks by using for loops.
Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the iterate macro that simplifies other tasks cannot be used in this context.
Hive already uses the for task from ant-contrib, which works great here. build.xml can be simplified by using the for task when preparing maven artifacts.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2961
AFFECTED FILES
build.xml
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6741/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Hive ant targets for publishing maven artifacts can be simplified
> -----------------------------------------------------------------
>
> Key: HIVE-2983
> URL: https://issues.apache.org/jira/browse/HIVE-2983
> Project: Hive
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Priority: Minor
> Attachments: HIVE-2983.D2961.1.patch
>
>
> Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the {{iterate}} macro that simplifies other tasks cannot be used in this context.
> Hive already uses the {{for}} task from ant-contrib, which works great here. {{build.xml}} can be simplified by using the for task when preparing maven artifacts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2983) Hive ant targets for publishing
maven artifacts can be simplified
Posted by "Travis Crawford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504274#comment-13504274 ]
Travis Crawford commented on HIVE-2983:
---------------------------------------
Re: publishing ant-tasks jar
Agreed, I don't think we need to publish. I'll update.
Re: special-casing exec
Exec is different because its not actually a subproject, its generated in the {{ql}} subproject directory. The fatjar issue has been discussed back & forth a lot now. If there's interest, I'd very much like to freshen up the patch discussed in https://issues.apache.org/jira/browse/HIVE-2424?focusedCommentId=13262898&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13262898
Let me know what you'd like to do regarding the exec jar. Given the number of issues about it, there's lots of community interest in thin jars (in addition to hive-exec).
> Hive ant targets for publishing maven artifacts can be simplified
> -----------------------------------------------------------------
>
> Key: HIVE-2983
> URL: https://issues.apache.org/jira/browse/HIVE-2983
> Project: Hive
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2983.D2961.1.patch
>
>
> Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the {{iterate}} macro that simplifies other tasks cannot be used in this context.
> Hive already uses the {{for}} task from ant-contrib, which works great here. {{build.xml}} can be simplified by using the for task when preparing maven artifacts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira