You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2025/02/06 23:00:51 UTC
[PR] avoid clearing server in cache when scanner closed and interrupted [accumulo]
keith-turner opened a new pull request, #5313:
URL: https://github.com/apache/accumulo/pull/5313
When the thread running an accumulo scanner is interrupted it may cause the server the scanner was reading from to be cleared from the cache. This can be disruptive in the case where the server is fine. This change makes a narrow exception to clearing the server from the cache for the case where the scanner was closed and an interrupt was seen. The reason this is so narrow is to avoid failing to invalidate the cache in the case where there is actually a problem with the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] avoid clearing server in cache when scanner closed and interrupted [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #5313:
URL: https://github.com/apache/accumulo/pull/5313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] avoid clearing server in cache when scanner closed and interrupted [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5313:
URL: https://github.com/apache/accumulo/pull/5313#issuecomment-2643038174
I looked at [TabletServerBatchReaderIterator](https://github.com/apache/accumulo/blob/2.1/core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java#L407) and am wondering if we should **not** invalidate the cache if the queryThreadPool is shutdown. I could not determine from looking at the code if that was needed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] avoid clearing server in cache when scanner closed and interrupted [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #5313:
URL: https://github.com/apache/accumulo/pull/5313#issuecomment-2660380513
> I looked at [TabletServerBatchReaderIterator](https://github.com/apache/accumulo/blob/2.1/core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java#L407) and am wondering if we should not invalidate the cache if the queryThreadPool is shutdown. I could not determine from looking at the code if that was needed or not.
I did not fully follow all the code, but if closing the batch scanner cause spurious exceptions in background threads which unnecessarily clear the cache then that would be a good change to make.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org