You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2025/03/02 19:14:17 UTC
[PR] reformat the python code with 'make reformat' and enable format in CI check [lucene]
rmuir opened a new pull request, #14322:
URL: https://github.com/apache/lucene/pull/14322
currently the python code has a mix of indentation, styles, imports ordering, etc. for example, it is very difficult to work with mixed indentation levels: the language is sensitive to indentation.
reformat all the code with 'make reformat' and enable format checks when linting. It works like spotless, just don't think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] reformat the python code with 'make reformat' and enable format in CI check [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14322:
URL: https://github.com/apache/lucene/pull/14322#issuecomment-2705096447
thank you @stefanvodita for reviewing (in both places). I am sure it won't go 100% smooth and there will be short-term problems, but I think in the long term it will make things easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] reformat the python code with 'make reformat' and enable format in CI check [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir closed pull request #14322: reformat the python code with 'make reformat' and enable format in CI check
URL: https://github.com/apache/lucene/pull/14322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] reformat the python code with 'make reformat' and enable format in CI check [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14322:
URL: https://github.com/apache/lucene/pull/14322#issuecomment-2705113695
it is merged, the squash-based merging is not useful for situations like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org