You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2025/09/27 11:10:12 UTC

[PR] fix: AceEditor Autocomplete Highlight [superset]

geido opened a new pull request, #35316:
URL: https://github.com/apache/superset/pull/35316

   ### SUMMARY
   Fixes #35313
   
   ### AFTER SCREENSHOTS OR ANIMATED GIF
   
   <img width="1489" height="389" alt="Screenshot 2025-09-27 at 14 07 45" src="https://github.com/user-attachments/assets/4ff659dc-6f50-4651-a233-64a3b92bc2bc" />
   
   ### TESTING INSTRUCTIONS
   1. Visit SQL Lab
   2. Change the SQL in the editor so that the autocomplete appears
   3. Highlight text should be visible in both dark and light mode
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: AceEditor Autocomplete Highlight [superset]

Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #35316:
URL: https://github.com/apache/superset/pull/35316


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: AceEditor Autocomplete Highlight [superset]

Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on code in PR #35316:
URL: https://github.com/apache/superset/pull/35316#discussion_r2387478989


##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx:
##########
@@ -193,6 +193,11 @@ const AceEditorWrapper = ({
             width: ${theme.sizeUnit * 130}px !important;
           }
 
+          .ace_completion-highlight {
+            color: ${theme.colorPrimaryText} !important;

Review Comment:
   Might be my eyes, but I feel `colorPrimaryTextActive` is less readable. @kasiazjc let me know if you have any feedback here. 
   
   With `colorPrimaryTextActive`:
   <img width="964" height="246" alt="Screenshot 2025-09-29 at 13 34 04" src="https://github.com/user-attachments/assets/307e48db-0d88-4907-abf1-2c7ec589f391" />
   
   With `colorPrimaryText`:
   <img width="816" height="249" alt="Screenshot 2025-09-29 at 13 36 34" src="https://github.com/user-attachments/assets/a916c124-4442-4bbd-8136-42df7bdd20d1" />
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: AceEditor Autocomplete Highlight [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #35316:
URL: https://github.com/apache/superset/pull/35316#discussion_r2384264657


##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx:
##########
@@ -193,6 +193,11 @@ const AceEditorWrapper = ({
             width: ${theme.sizeUnit * 130}px !important;
           }
 
+          .ace_completion-highlight {
+            color: ${theme.colorPrimaryText} !important;

Review Comment:
   `colorPrimaryTextActive` might be a tiny bit better, but LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org