You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Benedict Elliott Smith (Jira)" <ji...@apache.org> on 2022/05/10 16:58:00 UTC

[jira] [Commented] (CASSANDRA-17620) Incremental repair leaks SomeRepairFailedException after switch away from flatMap

    [ https://issues.apache.org/jira/browse/CASSANDRA-17620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534475#comment-17534475 ] 

Benedict Elliott Smith commented on CASSANDRA-17620:
----------------------------------------------------

+1

> Incremental repair leaks SomeRepairFailedException after switch away from flatMap
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17620
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17620
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Repair
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.1.x
>
>
> This is an extension of CASSANDRA-17549.
> Incremental repair used to do a flatMap where it returned a failed future of SomeRepairFailedException; this would not trigger our failure logging to log it due to the fact the executor didn’t know about it and RepairRunnable knew to ignore that error, a change was made to use map and throw the exception, and later that behavior was updated to trigger uncaughtException handling which leaks this exception.
> To roll back to previous behavior, we should switch back to flatMap to avoid this logging



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org