You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/08/31 05:47:57 UTC
[GitHub] [airflow] uranusjr commented on a diff in pull request #33932: Fix updating variables during variable imports
uranusjr commented on code in PR #33932:
URL: https://github.com/apache/airflow/pull/33932#discussion_r1311122201
##########
airflow/www/views.py:
##########
@@ -5146,8 +5147,13 @@ def varimport(self):
flash("Missing file or syntax error.", "error")
return redirect(self.get_redirect())
else:
+ skipped = set()
suc_count = fail_count = 0
for k, v in variable_dict.items():
+ if session.scalar(select(models.Variable).where(models.Variable.key == k)):
+ logging.warning("Variable: %s already exist, skipping.", k)
Review Comment:
```suggestion
logging.warning("Variable: %s already exists, skipping.", k)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org