You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 02:55:35 UTC

[GitHub] [airflow] josh-fell opened a new pull request #19956: Clean up incorrect class names of Google system tests

josh-fell opened a new pull request #19956:
URL: https://github.com/apache/airflow/pull/19956


   Some system tests in the Google provider were duplicated and/or were referencing a different service than what was being tested. This PR simply aligns the class names of these system tests to what's being tested.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell commented on pull request #19956: Clean up incorrect class names of Google system tests

Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #19956:
URL: https://github.com/apache/airflow/pull/19956#issuecomment-984745350


   > What’s the criteria you’re using to decide whether to prefix a class with `GCP` or not?
   
   That portion of the class names I didn't change. I did take a little liberty using "GCS" instead of "GoogleCloudStorage" if the class name was getting wildly long and unreadable. There didn't seem to be a clear naming convention that was followed so I just focused on making sure the name at least contained the name of related service based on the file name and example DAG.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #19956: Clean up incorrect class names of Google system tests

Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19956:
URL: https://github.com/apache/airflow/pull/19956#issuecomment-984307306


   What’s the criteria you’re using to decide whether to prefix a class with `GCP` or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #19956: Clean up incorrect class names of Google system tests

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19956:
URL: https://github.com/apache/airflow/pull/19956


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell edited a comment on pull request #19956: Clean up incorrect class names of Google system tests

Posted by GitBox <gi...@apache.org>.
josh-fell edited a comment on pull request #19956:
URL: https://github.com/apache/airflow/pull/19956#issuecomment-984745350


   > What’s the criteria you’re using to decide whether to prefix a class with `GCP` or not?
   
   That portion of the class names I didn't change. I did take a little liberty using "GCS" instead of "GoogleCloudStorage" if the class name was getting wildly long and unreadable. There didn't seem to be a clear naming convention that was followed. I just focused on making sure the class name at least contained the name of related service based on the file name and example DAG.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org