[jira] [Commented] (ARROW-7303) [C++] Refactor benchmarks to use new Result APIs

["Krisztian Szucs (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-7303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987278#comment-16987278 ] 

Krisztian Szucs commented on ARROW-7303:
----------------------------------------

We don't build the benchmarks indeed. I think a daily cron GHA job would be suitable, at least to exercise them. 

> [C++] Refactor benchmarks to use new Result APIs
> ------------------------------------------------
>
>                 Key: ARROW-7303
>                 URL: https://issues.apache.org/jira/browse/ARROW-7303
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.15.1
>            Reporter: Ben Kietzman
>            Assignee: Ben Kietzman
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When building benchmarks, I get the following error:
> {code}
> ../src/arrow/csv/converter_benchmark.cc:83:64: error: too many arguments to function call, expected 2, have 3
>     ABORT_NOT_OK(converter->Convert(parser, 0 /* col_index */, &result));
> {code}
> This was introduced by ARROW-7236. I guess the CI didn't catch it because we don't currently build benchmarks? [~apitrou] [~kszucs]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)