You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Andrzej Bialecki (Jira)" <ji...@apache.org> on 2021/10/21 17:54:00 UTC
[jira] [Commented] (SOLR-15708) Add ConfigSetAdminRequest.Upload
[ https://issues.apache.org/jira/browse/SOLR-15708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432646#comment-17432646 ]
Andrzej Bialecki commented on SOLR-15708:
-----------------------------------------
This looks good overall. A couple minor nits:
* there's {{ModifiableParams.setNonNull}} that we can use instead of explicit if-s, makes the code cleaner.
* I prefer using {{something == null}} instead of {{null == something}} as it feels more natural to me, and I think this is also prevalent in Solr code.
> Add ConfigSetAdminRequest.Upload
> --------------------------------
>
> Key: SOLR-15708
> URL: https://issues.apache.org/jira/browse/SOLR-15708
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15708.patch
>
>
> There's currently no SolrJ support for the {{/admin/configs?action=UPLOAD}} API
> The workaround is to use a {{ContentStreamUpdateRequest}} and set the appropriate path and params
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org