Re: [PR] feat(extensions): expose Superset categorical color schemes via @apache-superset/core/theme [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #39226:
URL: https://github.com/apache/superset/pull/39226#issuecomment-5351340124

   @sha174n good catch on the title, narrowed it since sequential/diverging schemes aren't bridged yet (just categorical for now). On `CategoricalSchemeRegistryLike`, the `as` cast is deliberate: it's a minimal duck-typed contract so `@apache-superset/core` doesn't pull in `@superset-ui/core`'s actual registry class. Agreed it means an incompatible upstream change wouldn't get caught by the type system, but that's the same tradeoff the rest of this declare-in-contract API makes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org