You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "ayushtkn (via GitHub)" <gi...@apache.org> on 2023/12/04 08:01:07 UTC

[PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

ayushtkn opened a new pull request, #318:
URL: https://github.com/apache/tez/pull/318

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #318:
URL: https://github.com/apache/tez/pull/318#issuecomment-1838265744

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m  0s |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m  5s |  https://github.com/apache/tez/pull/318 does not apply to master. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/TEZ/How+to+Contribute+to+Tez for help.  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | GITHUB PR | https://github.com/apache/tez/pull/318 |
   | JIRA Issue | TEZ-4522 |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/3/console |
   | versions | git=2.34.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #318:
URL: https://github.com/apache/tez/pull/318#issuecomment-1838433503

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 14s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   6m  0s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   9m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  6s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  compile  |   2m 30s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  checkstyle  |   2m 34s |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 27s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   2m 13s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +0 :ok: |  spotbugs  |   1m 16s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   0m 25s |  tez-tfile-parser in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 41s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 45s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javac  |   1m 45s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 36s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  javac  |   1m 36s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 16s |  tez-runtime-library: The patch generated 2 new + 63 unchanged - 0 fixed = 65 total (was 63)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  javadoc  |   1m 17s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   1m 15s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | -1 :x: |  findbugs  |   0m 13s |  tez-tfile-parser in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   2m 13s |  tez-api in the patch failed.  |
   | +1 :green_heart: |  unit  |   5m 34s |  tez-runtime-library in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 22s |  tez-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m  9s |  tez-dag in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 13s |  tez-tfile-parser in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 48s |  The patch does not generate ASF License warnings.  |
   |  |   |  63m 35s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | tez.common.TestTezCommonUtils |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/tez/pull/318 |
   | JIRA Issue | TEZ-4522 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
   | uname | Linux 9ab563e9f861 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/tez.sh |
   | git revision | master / 43562adc3 |
   | Default Java | Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | findbugs | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/artifact/out/branch-findbugs-tez-tools_tez-tfile-parser.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/artifact/out/diff-checkstyle-tez-runtime-library.txt |
   | findbugs | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/artifact/out/patch-findbugs-tez-tools_tez-tfile-parser.txt |
   | unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/artifact/out/patch-unit-tez-api.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/testReport/ |
   | Max. process+thread count | 1100 (vs. ulimit of 5500) |
   | modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-tfile-parser U: . |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/2/console |
   | versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #318:
URL: https://github.com/apache/tez/pull/318#issuecomment-1838824199

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  22m 48s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   6m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  11m 55s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 12s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  compile  |   2m 39s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  checkstyle  |   2m 55s |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 32s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   2m 19s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +0 :ok: |  spotbugs  |   0m 36s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 12s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 42s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javac  |   1m 46s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 36s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  javac  |   1m 36s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   1m 16s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  findbugs  |   4m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 17s |  tez-api in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 34s |  tez-runtime-library in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 24s |  tez-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 12s |  tez-dag in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 13s |  tez-tfile-parser in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 50s |  The patch does not generate ASF License warnings.  |
   |  |   |  90m 49s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/tez/pull/318 |
   | JIRA Issue | TEZ-4522 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
   | uname | Linux d1cd837a6a68 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/tez.sh |
   | git revision | master / 0ed5e3296 |
   | Default Java | Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   |  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/testReport/ |
   | Max. process+thread count | 2100 (vs. ulimit of 5500) |
   | modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-tfile-parser U: . |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/console |
   | versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #318:
URL: https://github.com/apache/tez/pull/318#issuecomment-1838149710

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  22m 43s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 51s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   9m 26s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  9s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  compile  |   2m 31s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  checkstyle  |   2m 34s |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 27s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   2m 12s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +0 :ok: |  spotbugs  |   1m 15s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   0m 25s |  tez-tfile-parser in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 12s |  tez-tfile-parser in the patch failed.  |
   | -1 :x: |  compile  |   0m 12s |  tez-tfile-parser in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04.  |
   | -1 :x: |  javac  |   0m 12s |  tez-tfile-parser in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04.  |
   | -1 :x: |  compile  |   0m 12s |  tez-tfile-parser in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08.  |
   | -1 :x: |  javac  |   0m 12s |  tez-tfile-parser in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08.  |
   | -0 :warning: |  checkstyle  |   0m 15s |  tez-runtime-library: The patch generated 2 new + 63 unchanged - 0 fixed = 65 total (was 63)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  javadoc  |   1m 16s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   1m 17s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | -1 :x: |  findbugs  |   0m 12s |  tez-tfile-parser in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   2m 15s |  tez-api in the patch failed.  |
   | +1 :green_heart: |  unit  |   5m 32s |  tez-runtime-library in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 23s |  tez-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m  8s |  tez-dag in the patch passed.  |
   | -1 :x: |  unit  |   0m 12s |  tez-tfile-parser in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 48s |  The patch does not generate ASF License warnings.  |
   |  |   |  85m 57s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | tez.common.TestTezCommonUtils |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/tez/pull/318 |
   | JIRA Issue | TEZ-4522 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
   | uname | Linux ea7d7674570a 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/tez.sh |
   | git revision | master / 43562adc3 |
   | Default Java | Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | findbugs | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/branch-findbugs-tez-tools_tez-tfile-parser.txt |
   | mvninstall | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-mvninstall-tez-tools_tez-tfile-parser.txt |
   | compile | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-compile-tez-tools_tez-tfile-parser-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04.txt |
   | javac | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-compile-tez-tools_tez-tfile-parser-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04.txt |
   | compile | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-compile-tez-tools_tez-tfile-parser-jdkPrivateBuild-1.8.0_392-8u392-ga-1~22.04-b08.txt |
   | javac | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-compile-tez-tools_tez-tfile-parser-jdkPrivateBuild-1.8.0_392-8u392-ga-1~22.04-b08.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/diff-checkstyle-tez-runtime-library.txt |
   | findbugs | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-findbugs-tez-tools_tez-tfile-parser.txt |
   | unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-unit-tez-api.txt |
   | unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/artifact/out/patch-unit-tez-tools_tez-tfile-parser.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/testReport/ |
   | Max. process+thread count | 1100 (vs. ulimit of 5500) |
   | modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-tfile-parser U: . |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/1/console |
   | versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #318:
URL: https://github.com/apache/tez/pull/318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #318:
URL: https://github.com/apache/tez/pull/318#issuecomment-1838578653

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 14s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 55s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  10m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  7s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  compile  |   2m 30s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  checkstyle  |   2m 52s |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 27s |  master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   2m 12s |  master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +0 :ok: |  spotbugs  |   1m 15s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   0m 26s |  tez-tfile-parser in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 39s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 45s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javac  |   1m 45s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 33s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  javac  |   1m 33s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 12s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  javadoc  |   1m 17s |  the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04  |
   | +1 :green_heart: |  javadoc  |   1m 16s |  the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08  |
   | +1 :green_heart: |  findbugs  |   4m 17s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 15s |  tez-api in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 34s |  tez-runtime-library in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 23s |  tez-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   6m  6s |  tez-dag in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 13s |  tez-tfile-parser in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 48s |  The patch does not generate ASF License warnings.  |
   |  |   |  66m 18s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/5/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/tez/pull/318 |
   | JIRA Issue | TEZ-4522 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml |
   | uname | Linux 42971aa7ce7f 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/tez.sh |
   | git revision | master / 43562adc3 |
   | Default Java | Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08 |
   | findbugs | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/5/artifact/out/branch-findbugs-tez-tools_tez-tfile-parser.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/5/testReport/ |
   | Max. process+thread count | 2101 (vs. ulimit of 5500) |
   | modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-tfile-parser U: . |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/5/console |
   | versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TEZ-4522: Use OpenFile where FileStatus is available. [tez]

Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #318:
URL: https://github.com/apache/tez/pull/318#issuecomment-1838826326

   latest precommit looks good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org