You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/12/30 04:37:44 UTC

[GitHub] [incubator-echarts] susiwen8 opened a new pull request #13904: Vertical singleaxis position

susiwen8 opened a new pull request #13904:
URL: https://github.com/apache/incubator-echarts/pull/13904


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   The `width` of `rect` should have affect on vertical `single axis` layour.
   
   
   
   ### Fixed issues
   
   Close #13784
   
   
   ## Details
   
   ### Before: What was the problem?
   
   ![Screen Shot 2020-12-30 at 12 37 15](https://user-images.githubusercontent.com/20318608/103330293-c7f46100-4a9b-11eb-92fd-e17dcb8c0b04.png)
   
   
   
   ### After: How is it fixed in this PR?
   
   ![Screen Shot 2020-12-30 at 12 36 20](https://user-images.githubusercontent.com/20318608/103330270-a98e6580-4a9b-11eb-90c0-eaa6ba748577.png)
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang commented on pull request #13904: Vertical singleaxis position

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13904:
URL: https://github.com/apache/incubator-echarts/pull/13904#issuecomment-753792106


   This change will put the axis in the center of rect, which is not expected I think. The axis should be on the left when vertical, as it should be on the bottom when horizontal. 
   
   Also, I noticed the issue is about the NaN value in SVG render mode. I'm not sure about the relationship between this fix and the issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13904: Vertical singleaxis position

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13904:
URL: https://github.com/apache/incubator-echarts/pull/13904#issuecomment-752324955


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #13904: Vertical singleaxis position

Posted by GitBox <gi...@apache.org>.
susiwen8 edited a comment on pull request #13904:
URL: https://github.com/apache/incubator-echarts/pull/13904#issuecomment-757635874


   > Also, I noticed the issue is about the NaN value in SVG render mode. I'm not sure about the relationship between this fix and the issue.
   
   @pissang  `NaN` was cause by missing `position` for `singleAxis`
   ```js
   {
       id: idx,
       orient: 'vertical',
       top: 6,
       //bottom:0,
       type: 'category',
       boundaryGap: false,
       data: hours,
       left: idx * (100),
       //height: 80,
       axisLabel: {
           interval: 2
       },
       width: 400,
       position: 'left'
   }
    ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on pull request #13904: Vertical singleaxis position

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13904:
URL: https://github.com/apache/incubator-echarts/pull/13904#issuecomment-757635874


   > Also, I noticed the issue is about the NaN value in SVG render mode. I'm not sure about the relationship between this fix and the issue.
   
   `NaN` was cause by missing `position` for `singleAxis`
   ```js
   {
       id: idx,
       orient: 'vertical',
       top: 6,
       //bottom:0,
       type: 'category',
       boundaryGap: false,
       data: hours,
       left: idx * (100),
       //height: 80,
       axisLabel: {
           interval: 2
       },
       width: 400,
       position: 'left'
   }
    ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org