You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Radu Cotescu (JIRA)" <ji...@apache.org> on 2017/03/13 14:41:41 UTC

[jira] [Commented] (SLING-6639) Move ResourceResolution & SightlyException to java-compiler bundle

    [ https://issues.apache.org/jira/browse/SLING-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907583#comment-15907583 ] 

Radu Cotescu commented on SLING-6639:
-------------------------------------

The engine bundle does export {{org.apache.sling.scripting.sightly}}. See https://github.com/apache/sling/tree/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly.

Moving those classes into the {{java-compiler}} would make that module dependent of the Sling API, when it actually shouldn't.

> Move ResourceResolution & SightlyException to java-compiler bundle
> ------------------------------------------------------------------
>
>                 Key: SLING-6639
>                 URL: https://issues.apache.org/jira/browse/SLING-6639
>             Project: Sling
>          Issue Type: Task
>          Components: Scripting
>            Reporter: Tomek Rękawek
>             Fix For: Scripting HTL Engine 1.0.34, Scripting HTL Java Compiler 1.0.10
>
>         Attachments: SLING-6639.patch
>
>
> {{ResourceResolution}} and {{SightlyException}} classes should be moved to the java-compiler bundle, as this is the one exporting {{org.apache.sling.scripting.sightly}} package. Right now they are the part of the engine bundle, which doesn't export anything and it may lead to issues if some bundle tries to use these two classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)